Skip to content

Google Sheets: small cleanup#83685

Merged
allenporter merged 7 commits into
home-assistant:devfrom
tronikos:google-sheets
Dec 10, 2022
Merged

Google Sheets: small cleanup#83685
allenporter merged 7 commits into
home-assistant:devfrom
tronikos:google-sheets

Conversation

@tronikos
Copy link
Copy Markdown
Member

@tronikos tronikos commented Dec 9, 2022

Proposed change

Small cleanup in Google Sheets integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Dec 9, 2022

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (google_sheets) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_sheets can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign google_sheets Removes the current integration label and assignees on the issue, add the integration domain after the command.

@tronikos
Copy link
Copy Markdown
Member Author

tronikos commented Dec 9, 2022

@allenporter PTAL. I removed the async_entry_has_scopes check per your comment in #82328 along with some other small code improvements.

tkdrob
tkdrob suggested changes Dec 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see PR: #79149

The removed pieces here will be needed there.

@tronikos
Copy link
Copy Markdown
Member Author

tronikos commented Dec 9, 2022

Should I revert 63e24f8 commit and keep the other 5 commits?

@tkdrob
Copy link
Copy Markdown
Contributor

tkdrob commented Dec 9, 2022

Let's see what Allen says. I could just add back the other pieces needed during a merge commit.

@allenporter
Copy link
Copy Markdown
Contributor

allenporter commented Dec 10, 2022

I'm fine with leaving given you're about to use it 👍🏼

On the reauth text change: I think reauth will still happen if creds are invalid as the config entry is setup. Do the reauth strings and steps need to stay?

@tronikos
Copy link
Copy Markdown
Member Author

tronikos commented Dec 10, 2022

I reverted "Remove async_entry_has_scopes check" commit.

Allen, my changes in strings.json remove a duplicate object key.

allenporter
allenporter approved these changes Dec 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@allenporter allenporter merged commit 2cfdae0 into home-assistant:dev Dec 10, 2022
@tronikos tronikos deleted the google-sheets branch December 10, 2022 22:57
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@allenporter allenporter allenporter approved these changes

+1 more reviewer

@tkdrob tkdrob tkdrob requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed code-quality has-tests integration: google_sheets Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tronikos @tkdrob @allenporter